Variadic expressions #1611
Merged
Variadic expressions #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
variadic-expressions
branch
2 times, most recently
from
f3b4511
to
7a6248f
Compare
Adds a new VarArgsExpr/VarArgs pair of objects for representing sequences of known types but unknown length in the expression tree. This allows us to use multipledispatch to define compute handlers for expressions that conceptually accept a sequence like `Merge`. This also implements `Merge` as a variadic expression. Future work will be porting `Concat`.
llllllllll
force-pushed
the
variadic-expressions
branch
from
7a6248f
to
78915b2
Compare
|
NOTE: I didn't implement this for the spark backend because I have no idea how to fix that. I will leave it unimplemented for now. |
|
ping @necaris. Do you have any thoughts on the implementation of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new VarArgsExpr/VarArgs pair of objects for representing
sequences of known types but unknown length in the expression tree. This
allows us to use multipledispatch to define compute handlers for
expressions that conceptually accept a sequence like
Merge.This also implements
Mergeas a variadic expression.Future work will be porting
Concat.