<TooltipIconButton> Tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wraps the component with the requisite theme provider.
| * @return {Object} React component | ||
| */ | ||
| export function TooltipIconButton({ | ||
| export const TooltipIconButton = ({ |
There was a problem hiding this comment.
So we were using more modern syntax but there was something about function that worked better. I forget what. Is there a reason to prefer const here besides shorter?
There was a problem hiding this comment.
I suggest reverting this to function as it's more consistent with the rest of our code. I think the rule we're using is "top-level exported functions should use function keyword". I'll add that to styleguide.
There was a problem hiding this comment.
OlegMoshkovich
pushed a commit
to OlegMoshkovich/Share
that referenced
this pull request
May 19, 2022
* Create manual mock for testing React components This wraps the component with the requisite theme provider. * Convert component to ES6 arrow function * Add tests for <TooltipIconButton> * Refactor to remove redundant inline wrapper * Add internal attribute to support testing * Add missing blank lines after imports * Reorder file context so name of first object corresponds with filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the supporting infrastructure for manual mocking of components, and two tests for .
Small, optional bonus of converting from ES5 function to ES6 fat arrow function.