Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Material icon family #180

Merged
merged 2 commits into from May 7, 2022

Conversation

oogali
Copy link
Contributor

@oogali oogali commented Apr 13, 2022

This was consistently raising a 404 error in the console due to previous link being invalid.

This was consistently raising a 404 error in the console due to previous link being invalid.
@pablo-mayrgundter
Copy link
Member

Please post a link to your GHP running this branch as a QA check for me. Thanks!

Adding Oleg since he setup the fonts initially.

@pablo-mayrgundter
Copy link
Member

Ping.. Oleg, can you review and Ogali, I think we need a merged build

@OlegMoshkovich
Copy link
Member

OlegMoshkovich commented May 2, 2022

@oogali
There are conflicts within the built files.
I usually do rebase to the main branch and accept all incoming.

# Conflicts:
#	docs/index.js
#	docs/index.js.map
@pablo-mayrgundter pablo-mayrgundter merged commit 5d23c63 into bldrs-ai:main May 7, 2022
OlegMoshkovich pushed a commit to OlegMoshkovich/Share that referenced this pull request May 19, 2022
This was consistently raising a 404 error in the console due to previous link being invalid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants