Specify type assertion for JSON import #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this is also addressed as part of PR #191 (which also includes updated linting to account for the type assertion statement). |
|
I think it makes sense to keep this separate -- we can get this fix in without requiring us to take an immediate position on Gitpod yet. |
|
Good point. In this case, I suggest also adding the |
|
@shafy In my branch, I did not add that module so I'm curious why I don't receive any errors regarding
|
|
@shafy Never mind, I see that it's not being tested... I'll add it to the lint inputs and incorporate your module changes too. |
|
Looks great to me! |
OlegMoshkovich
pushed a commit
to OlegMoshkovich/Share
that referenced
this pull request
May 19, 2022
* Specify type assertion for JSON import * bldrs/Share#194: Ensure all project JS files are checked by linter * bldrs/Share#194: Add ESLint plugin (and configuration) for import assertions * bldrs/Share#194: Fix lint errors in version generation logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.