Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand regex to match attributes with single quotes #250

Merged
merged 7 commits into from
Jul 8, 2022
Merged

Expand regex to match attributes with single quotes #250

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eaa935b
Expand regex to match attributes with single quotes
oogali Jul 8, 2022
05327bb
Stricter matching of double OR single quote
oogali Jul 8, 2022
3a1a55a
Reduce scope availability of image URL variable
oogali Jul 8, 2022
e47d1de
Refactor image extraction logic into its own function
oogali Jul 8, 2022
0ff10ae
Add unit test for image URL extraction
oogali Jul 8, 2022
32db7ce
Convert to arrow function
oogali Jul 8, 2022
0574683
Add additional test cases for image URL extraction
oogali Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Components/IssuesControl.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {TooltipIconButton} from './Buttons'
import {removeHashParams} from '../utils/location'
import {setCameraFromEncodedPosition, addCameraUrlParams, removeCameraUrlParams} from './CameraControl'
import {addHashParams} from '../utils/location'
import {isRunningLocally} from '../utils/network'


/** The prefix to use for issue id in the Url hash. */
Expand Down Expand Up @@ -136,8 +135,13 @@ export function Issues() {

if (issue.body.includes('img')) {
const isolateImageSrc = issue.body.split('src')[1].split('imageURL')[0]
const imageSrc = isolateImageSrc.match(/"([^"]*)"/)
imageUrl = isRunningLocally() ? imageUrl = isolateImageSrc : imageSrc[1]

// Match either single or double quote-wrapped attribute
// <img src = "..." /> OR <img src = '...' />
const imageSrc = isolateImageSrc.match(/"([^"]*)"|'([^']*)'/)

// Then filter out the non-matched capture group (as that value will be undefined)
imageUrl = imageSrc.slice(1).filter((u) => u !== undefined)[0]
} else {
imageUrl = ''
}
Expand Down