<SideDrawer> testing with React Router #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
||
| useEffect(() => { | ||
| const issueHash = getHashParams(window.location, 'i') | ||
| const issueHash = getHashParams(location, 'i') |
| // expect(screen.getByText('BLDRS-LOCAL_MODE-ID:1257156364')).toBeInTheDocument() | ||
| // }) | ||
| const {getByText} = render( | ||
| <MemoryRouter initialEntries={['/v/p/index.ifc#i:1257156364::c:-26.91,28.84,112.47,-22,16.21,-3.48']}> |
There was a problem hiding this comment.
this is nice!
https://v5.reactrouter.com/web/api/MemoryRouter
OlegMoshkovich
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for
<SideDrawer>interaction with hash parameters provided via React Router.It no longer tries to reach directly into the browser for location but relies on what's provided/mapped by React Router via
useLocation.Fixes #249.