Viewer: CutPlane: Created cut plane form normal and point

[OlegMoshkovich]

This PR is addressing #153.

• Add a basic menu to the cut plane UI that allows the user to create a cut plane at the center of the model on one of the axes.
• Introduce plane hash URL(:p) parameter.
• At the moment only a single plane can be created which simplifies the issue of sharing the cut plane in the permalink.
• The menu buttons have a toggle state and can be deselected.
• deselecting the cut plane clears the URL parameter.

https://deploy-preview-332--bldrs-share.netlify.app/share/v/gh/Swiss-Property-AG/Portfolio/main/ASTRA.ifc#p:z::c:-3.98,12.13,-51.23,18.61,6.65,-8.62

[netlify]

✅ Deploy Preview for bldrs-share ready!

Name	Link
🔨 Latest commit	1e1bf06
🔍 Latest deploy log	https://app.netlify.com/sites/bldrs-share/deploys/631b350b8c18060009889a27
😎 Deploy Preview	https://deploy-preview-332--bldrs-share.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[pablo-mayrgundter]

Heya, I think this still qualifies as draft since it's not working quite yet. Sound right?

[OlegMoshkovich]

yes, not sure why it is switched to normal pr.

[OlegMoshkovich]

@pablo-mayrgundter were you able to get any more clarity about why the plane is not cutting through the model?

[mkeshavarzi]

Looks great!

[OlegMoshkovich]

@pablo-mayrgundter PTAL

[pablo-mayrgundter]

Tests please. Likes in issues, url -> function, button -> function, clear.

[pablo-mayrgundter]

Is it intended that only one cut plain is active at a time? Would be nice to support multiple if it fits in this PR.

[OlegMoshkovich]

Yes one for now.
The scope feels right, and useful.

[OlegMoshkovich]

tests .. yes, will add.

[OlegMoshkovich]

Testing successfully getting to create plane function.
It requires a viewer.
how do we test viewer functionality?

[pablo-mayrgundter]

if you're testing A, and A calls B, and B is a mess to test, then you "mock" B

jest.mock('../B')
const b = require('../B')

// b is a mock function
b.mockImplementation(() => 42)
b()
// > 42

See docs here: https://jestjs.io/docs/mock-functions#mock-implementations

[OlegMoshkovich]

I see.. so in this case we would need to create viewer mock which contains a clipper and deleteAllPlaces methods?

[OlegMoshkovich]

@pablo-mayrgundter created checklist in the #153
everything is complete besides the tests, and those are stubbed out.
Can you please help with the test to make it production ready?
This is issue is on a critical path.

[pablo-mayrgundter]

Ok, please merge in #358, with the improved web-ifc-viewer mock. Then try following the CadView.test for how to go from URL -> asserts on IFCjs.

[pablo-mayrgundter]

Heya, looking back at your original question about testing, you'll want to add a jest.fn() mock method to mocks/web-ifc-viewer.js for viewer.clipper.deleteAllPlanes and assert on it after your code-under-test. Hope that helps!

[OlegMoshkovich]

@pablo-mayrgundter PTAL

[pablo-mayrgundter]

Wowow! Super jağ!