Tests: Introduce CadView.test.jsx #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Ok, tested camera controls and looks like it works. Flipped to ready. Ogali's going to do review... |
OlegMoshkovich
changed the title
… react warning. Improve Tree selection visibility in dark theme. Misc debugging.
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I branched this off of Oleg's work on the selectionBug in #339 to help him improve testing there. It turned into a significant refactor.
There's now a direct method for testing from URL -> mock asserts on the IfcViewerAPI. I found a lot of little bugs while doing this and fixed them here to get the tests passing robustly.