Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad/missing imports #363

Merged
merged 3 commits into from Aug 31, 2022
Merged

Fix bad/missing imports #363

merged 3 commits into from Aug 31, 2022

Conversation

oogali
Copy link
Contributor

@oogali oogali commented Aug 30, 2022

PR to clean up issue regarding ES6 imports:

  • Some imports weren't directly referenced. This means if the parent dependencies were removed from the project for whatever reason (e.g. refactor), other portions of the code would appear to no longer work.
  • Correct reference to react-router-dom

This PR also removes some unused code regarding Google Analytics, which could not possibly work because:

  1. the import it required was not installed in the project, and
  2. it contained placeholder GA IDs.

The lack of the direct references worked because there are other modules in the project that pulled these dependencies in indirectly.
@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 3192c85
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/630e642c569fdf0009d5c66c
😎 Deploy Preview https://deploy-preview-363--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OlegMoshkovich
Copy link
Member

LGTM

@oogali oogali merged commit 205d46e into bldrs-ai:main Aug 31, 2022
@oogali oogali deleted the fix-broken-imports branch September 4, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants