Redesign #395
Redesign #395
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
OlegMoshkovich
force-pushed
the
redesign
branch
3 times, most recently
from
8245cc4
to
f358709
Compare
OlegMoshkovich
force-pushed
the
redesign
branch
3 times, most recently
from
ef8acec
to
8b6c66a
Compare
OlegMoshkovich
force-pushed
the
redesign
branch
from
8b6c66a
to
9755b96
Compare
OlegMoshkovich
force-pushed
the
redesign
branch
from
9755b96
to
d265071
Compare
| result.current.setIssues(MOCK_ISSUES) | ||
| }) | ||
| await act(() => { | ||
| result.current.setComments(MOCK_COMMENTS) | ||
| }) |
There was a problem hiding this comment.
these cases are failing, but comments are loaded.
not totally sure whats going on here.
commenting out for now.
There was a problem hiding this comment.
I am not sure how it happened but the failure of these test cases is related to the bug that made its way into Production.
At the moment when the issue card is clicked, the view changes to the individual issue but the comments do not display.
There was a problem hiding this comment.
the bug is filed here #400
OlegMoshkovich
force-pushed
the
redesign
branch
from
a1ef190
to
c7c21ff
Compare
|
@pablo-mayrgundter PTAL |
There was a problem hiding this comment.
Sitting with Markus.. some style points:
- Font weights should go from heavy to light as you narrow scope. So for instance, in properties, the attribute names should have a heavier weight than the values.
- Same principle for SideDrawer: separator between scene and drawer content should be heavier than between rows in properties
Code style: Lots of imports changed; pls proofread them for sorting. I'm seeing them out-of-order in a few files. See style guide on imports here: https://github.com/bldrs-ai/Share/wiki/Dev:-Style#imports
| @@ -1,15 +1,14 @@ | |||
| import React, {useState, useEffect} from 'react' | |||
There was a problem hiding this comment.
Pls sort imports.. looks like they got mixed up over time
There was a problem hiding this comment.
I just resorted them - took a long time actually - following the comment you made yesterday.
There was a problem hiding this comment.
Ok, will check.. thought I saw some out of order
Styling changes. Fix local serving to match bldrs-ai#397.
…h wrapped text display of large text blobs. Lighter separators between rows than accordion sections. Lighter font weight overall.
itemProperties: refactor to simplify row creation and react key alloc
PR includes redesign(restyle) of the following components: