Restore live-reloading. Fix 404 bounce handler! #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
oo-bldrs
approved these changes
Sep 20, 2022
pablo-mayrgundter
added a commit
to pablo-mayrgundter/Share
that referenced
this pull request
Sep 22, 2022
OlegMoshkovich
added a commit
to OlegMoshkovich/Share
that referenced
this pull request
Sep 23, 2022
Styling changes. Fix local serving to match bldrs-ai#397.
OlegMoshkovich
added a commit
that referenced
this pull request
Sep 23, 2022
* squash * update * clean up * properties container styles * subtract tooltips for mobile * re-order imports * re-order the imports * include scrollIcon in the prop row if the length of the property is too long * add camera positions to the sample projects * adjust logo camera position on mobile * add bullet points to the about description * test mobile alignment of the bullet in about control * revert changes to about description * change the font weightl of the key and value * about and share dialogs * re order imports * Styling changes. Fix local serving to match #397. * Use CSS hover styling to reveal large text. * space clean up * space clean up * theme adjustments * align notes * ItemProperties: restore table layout, with double-click for full-width wrapped text display of large text blobs. Lighter separators between rows than accordion sections. Lighter font weight overall. * them line color and notes styles * fix the about text sizes * about variant * small font tweak * small font tweak * about details * style dividers * adjust values * rewire open models * itemProperties: refactor to simplify row creation and react key allocation. * add sample projects * toggle notes, placed pointer curson on the table row * add sample project * add camera to sample Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the live-reload bug.
I bisected it down to cleanPlugin. No idea why that was causing trouble. Maybe related, there's no contents in the docs directory.. esbuild keeps the build in memory.
ALSO..... Fixed the 404 bounce to work locally. Not sure this ever worked before :(. I hadn't set the proxy up right.
We can finally reload any URL no problem!