Introduce tsc for some whitelisted jsdoc checks in src/utils. #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
oo-bldrs
reviewed
Dec 19, 2022
oo-bldrs
reviewed
Dec 19, 2022
|
PTAL |
oo-bldrs
reviewed
Dec 19, 2022
oo-bldrs
reviewed
Dec 19, 2022
oo-bldrs
reviewed
Dec 19, 2022
|
Can we not exclude the multi-megabyte output of the dependency graph results so they're not committed to the repository? |
|
PTAL |
pablo-mayrgundter
requested review from
oo-bldrs
and removed request for
oogali and
oo-bldrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a dependency diagram generator and check the first graph in.
To use this, just run use
yarn lintas usual. It will now include a jsdoc type check for the files listed in the tsconfig.