New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VYZN: Viewer: UI configuration via Matrix config message #525
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
It's weird that the load-sample-model e2e test pass for me locally, but "sometimes" fail when triggered by the github action. |
Hi Ibrahim! Looks good overall. We have a fix underway for the e2e test.. will try to get it in tomorrow. Hopefully that fixes the issue for you too. One high-level comment on the UI config. I'm not sure it makes sense to have individual button enable toggles. Do you guys have use-cases for that? I'll go back to the bug for more discussion... |
…into feat/ui-config
…into feat/ui-config
@pablo-mayrgundter Hi Pablo! I modified the implementation to be more coarse in hiding/showing UI components. (per button group). Is this making more sense now? |
Hi Ibrahim! Thanks for waiting to get #455 in. Could you merge and we'll go from there? Thanks.
Yes, great, thanks! |
@Ibrahim5aad can you please join our discord? |
Hi @pablo-mayrgundter, conflicts are fixed, and this PR is ready to get through now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looking pretty good. One refactor in Utils.
Also, let's avoid including Momentum (5MB) as a test asset. Can you use a constructed IFC to get what you need? Here's a minimal IFC file to start with:
https://discord.com/channels/853953158560743424/945373774402945074/1048365704077910096
This PR refactors the underlying classes for the widget API communication mechanism that allows the Share app to be treated as an iframe-embeddable app that supports receiving and sending messages back and forth with the embedding apps.
The main theme for this PR is supporting #391 UI configuration via this previously mentioned widget API mechanism.
The PR also stabilizes the e2e tests for this API integration and adds the required test for the new functionality UI configuration.
09/01 Update: Closes #391, closes #515, closes #516, closes #517.