VYZN: Matrix Messaging Integration #455
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The title of this PR should be changed to reflect the contents, which if I'm guessing correctly is: Matrix Messaging Integration? |
|
Here's our style guide: https://github.com/bldrs-ai/Share/wiki/Dev:-Style Please use our eslint config or run |
|
Per discussion, I'd try useMemo or useCallback for the init logic. Assuming that works, the right place is probably in src/Share.jsx. |
…tour in the store, add event emitter
clecherbauer
force-pushed
the
bldrs-to-vyzn
branch
from
aa020f2
to
301b66c
Compare
|
Hey Christian, how's this going? |
|
@pablo-mayrgundter i still need to write tests. Could you do another review now before is start with that? |
VYZN-806: Tests for Bldrs integration
|
Hmm, I'm not seeing the netlify dialog change. can you try updating smth like that yarn.lock and see if that triggers it? |
|
OK, i did update yarn.lock. But does not seem like it triggered the deployment. We really need to have the current version of this code deployed since the viewer in our production is loaded from this preview-instance. |
|
I manually flushed the build cache and retried the build which appeared to have deployed successfully. Does the deploy preview reflect your changes? |
|
yes, thank you |
Porting bldrs-ai#455 changes, and Fixes for issues bldrs-ai#515,bldrs-ai#516,bldrs-ai#517
OlegMoshkovich
changed the title
|
Hey Adrian, I'm reluctant to abandon this PR.. we had a bunch of comments in flight. Can we continue here? |
|
Per discussion with Adrian yesterday, Christian, please do finish this out. I think we're good to go but pending a successful merge and final review (hopefully a no-op). |
Fixing Failing tests, linting and merging with Share/main head
|
@pablo-mayrgundter Hi Pablo, @aozien has rebased and fixed my changes. I think we're ready for your final review now :) |
|
Looks like we got broken somehow :( I tried loading a model and got this error. I see some maybe related changes in the last update.
|
|
@pablo-mayrgundter It turns out the problem was caused by the (yarn.lock) file re-generated in commit (a8ed57d), since that did some minor-version updates to some packages, which caused some functionality to break. |
|
Works for me now, thanks. Found another issue.. permalinks for camera and cutplane are broken :( When I follow this link, everything after the index.ifc is removed after load. Same on a loaded model. Please fix that and add an integration test for it. Thank you! |
|
@pablo-mayrgundter this should be fixed now as well :) |
Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
|
Finally! Congrats guys! |
This pull request implements the lib "matrix-widget-api" which allows us to send control-messages to an embedded (iframe) bldrs instance.
Messages bldrs can receive:
Messages bldrs will emit: