Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Properties to back to OperationsGroup #841

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

pablo-mayrgundter
Copy link
Member

Also:

  • Fix multi viewer/three.js warning in ElementGroup.test
  • lint: sort imports, line length

… warning in ElementGroup.test. lint: sort imports, line length.
@pablo-mayrgundter pablo-mayrgundter added the enhancement New feature or request label Nov 9, 2023
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 72efcab
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/654d18725b78800008db849a
😎 Deploy Preview https://deploy-preview-841--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0 (🔴 down 29 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 72efcab
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/654d1872a1a081000825c73c
😎 Deploy Preview https://deploy-preview-841--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter merged commit 483eb18 into bldrs-ai:main Nov 9, 2023
13 checks passed
@pablo-mayrgundter pablo-mayrgundter deleted the props-right branch November 9, 2023 17:41
OlegMoshkovich pushed a commit to OlegMoshkovich/Share that referenced this pull request Nov 16, 2023
… warning in ElementGroup.test. lint: sort imports, line length. (bldrs-ai#841)
OlegMoshkovich pushed a commit to OlegMoshkovich/Share that referenced this pull request Dec 3, 2023
… warning in ElementGroup.test. lint: sort imports, line length. (bldrs-ai#841)
OlegMoshkovich pushed a commit to OlegMoshkovich/Share that referenced this pull request Dec 6, 2023
… warning in ElementGroup.test. lint: sort imports, line length. (bldrs-ai#841)
pablo-mayrgundter added a commit that referenced this pull request Feb 3, 2024
* Theme update (#838)

* SideDrawer Details (#839)

* Move Properties to back to OperationsGroup.  Fix multi viewer/three.js warning in ElementGroup.test.  lint: sort imports, line length. (#841)

* add loader test

* timeline

* add the hash of a commit to commit data array

* add reset button to the version history panel that navigates to main

* add reset to the tip of the history in the timeline

* add no content message to the timeline

* loggin the commits

* fix debug log problem

* create mocks

* add the mocks for the branches and for commits

* trying to resolve the versin history test

* adjust the version history panel tests

* sort out the test

* clean up cad view comment

* clean up cadview test

* adjst commit

* add the version history panel test

* refactor version container

* refactor version container

* fix one of the timeline tests

* adjust the version container test and subrtract branched control from the cadview

* fix styles in versions conteiner

* fix application error font color

* fix timeline fixture

* change the title of versions button

* address comments

* re work versions timeline

* changed the PII to general

* placement of panels

* subtract sp information

* reduce wait time for commit fetch

* add the reset action to the panel

* align panel with share button

* decrease opacity

* eidt descriptions

* add active version to the store

* add logging to the versions

* add loging to versions timeline

* fix logging

* fix versions

* move state to local

* fix test

* Fix disappearance of the future.

---------

Co-authored-by: OlegMoshkovich <oleg.mosh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants