Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline load - fixing disappearing future #960

Merged
merged 48 commits into from Feb 3, 2024

Conversation

pablo-mayrgundter
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter commented Feb 2, 2024

We had been discovering commits with /commits?sha=<hash> which gets commits up to that sha.

This PR switches to use /commits?path=<path to file> to get all commits related to that file.

It also adds some logic to compare the current URL's file ref to the commit ref in the Timeline to highlight the active commit within the list.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit c677e2a
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65bd98f1fbad170009340ee4
😎 Deploy Preview https://deploy-preview-960--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 1 from production)
Accessibility: 80 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit c677e2a
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/65bd98f1d9b885000888daf2
😎 Deploy Preview https://deploy-preview-960--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter marked this pull request as ready for review February 3, 2024 01:46
@pablo-mayrgundter
Copy link
Member Author

All set!

@pablo-mayrgundter pablo-mayrgundter self-assigned this Feb 3, 2024
@pablo-mayrgundter pablo-mayrgundter added this to the Story: Save new version milestone Feb 3, 2024
@pablo-mayrgundter pablo-mayrgundter merged commit cb5490a into bldrs-ai:main Feb 3, 2024
13 checks passed
@pablo-mayrgundter pablo-mayrgundter deleted the Timeline_load branch February 3, 2024 09:55
@OlegMoshkovich OlegMoshkovich modified the milestones: Story: Save new version, Versions Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants