This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix build with vala 0.46 #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is on behalf of NixOS packaging, as in its latest released version it was failing to build |
|
Here's a version of the patch that applies to the released version
|
worldofpeace
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Oct 14, 2019
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 15, 2019
See: bleakgrey/tootle#164 (cherry picked from commit 836d2ee)
|
This issue has been already resolved in the |
|
Understood @bleakgrey, though having a stable release that doesn't build with latest vala isn't great for people that distribute this application. So I'd recommend having some sort of fix for a stable release. Thanks for fixing it on the refactor branch ✨. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://gitlab.gnome.org/GNOME/vala/issues/766
Fixes #163