Re-submit PR #40 to eliminate use of state/node files in temp directory #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVE-2013-4184 discusses the insecure usage of `/tmp/.UUID_STATE` and `/tmp/.UUID_NODEID`, due to a potential symlink attack. Unfortunately, this code is old enough that none of the current maintainers fully understand the history of the code, nor do we have sufficient context from the commit history. Rather than attempting to address this vulnerability by changing the location of where these files are written, or by adding additional logic to ensure that they are handled securely, this patch addresses the issue by eliminating the need for these two files completely.
Now that we are no longer saving any context (of either the Node, or the State), we no longer need to maintain a "when should we do the next save?" field in the UUID context.
We no longer save any State/Node files to disk, so we do not need to keep track of what the requested umask was for those files.
We no longer save State/Node files out to disk, and so we no longer require the option to specify what directory those files should be recorded or saved to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A re-submission of #40, which eliminated the use of state/node files in a predictable location, to address the vulnerability outlined by CVE-2013-4184.
Since #40 was first submitted, repo ownership had been transferred, and as a result I had to blow away my forked copy of the repository. Thus the need for a re-submission, as the original PR was closed when the repository was destroyed.