fix(job): log was too long (closes #556) #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've restarted the build and it didn't crash this time - so I guess that it works. |
|
|
jkuri
reviewed
Aug 16, 2021
| @@ -5,7 +5,7 @@ type ( | |||
| EnvVariable struct { | |||
| ID uint `gorm:"primary_key;auto_increment;not null" json:"id"` | |||
| Key string `gorm:"not null" json:"key"` | |||
| Value string `gorm:"not null" sql:"type:text" json:"value"` | |||
| Value string `gorm:"not null" sql:"type:longtext" json:"value"` | |||
There was a problem hiding this comment.
this only works for mysql unfortunately.
There was a problem hiding this comment.
Hm, I have no idea how to fix it for sqlite, except for truncating the actual value...
There was a problem hiding this comment.
As far as I tested, longtext works just fine in here with sqlite3 as backend, and if I got the docs correctly - sqlite doesn't limit the size.
There was a problem hiding this comment.
Tnx for the test, i will also test it and let you know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #556, caused by the log being too long to fit in the table
I didn't test it (yet), but it should fix the issue.