Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latex formatting in notebooks #586

Merged
merged 5 commits into from
Mar 27, 2017
Merged

Conversation

napsternxg
Copy link
Contributor

Closes #585

@dustinvtran
Copy link
Member

dustinvtran commented Mar 24, 2017

Thanks! This looks great. It's nice that the fix is as simple as adding line breaks.

Some comments:

  • The equation/align environments in gan.ipynb are still broken.
  • The equation/align environments in unsupervised.ipynb are still broken.
  • The <img src=...> lines in gan.ipynb aren't rendering. It seems like Markdown's syntax for displaying images will also work for displaying them in the Github/Jupyter notebook viewers.
  • the
``text''

lines were accidentally carried over when transferring text from their corresponding tex file. Can you change them all to be "text"?

  • In linear_mixed_effects_models.ipynb, can you replace \citep{gelman2006data} with (Gelman & Hill, 2006)?
  • Empty cell accidentally added to unsupervised.ipynb.

@napsternxg
Copy link
Contributor Author

@dustinvtran added the suggested fixes.

@dustinvtran
Copy link
Member

dustinvtran commented Mar 25, 2017

Thanks again. Additional comments:

  • The equation/align environments in gan.ipynb are still broken.
  • The equation/align environments in unsupervised.ipynb are still broken.
  • Empty cell accidentally added to bottom of gan.ipynb.
  • Empty cell accidentally added to bottom of unsupervised.ipynb .
  • You used various forms of italics and bolds to replace the ``text'' lines. Why not "text" (i.e., wrapping the phrases with literal quotation marks)? The latter remains consistent with the rendering on the tutorial webpages.
  • Upon closer look, it seems like you use $$ to separate the equation/align environments and properly render them. What if you just add blanklines instead? Does that not render correctly?

@napsternxg
Copy link
Contributor Author

@dustinvtran This should be good.

@dustinvtran
Copy link
Member

LGTM. Thanks again.

@dustinvtran dustinvtran merged commit 3731a31 into blei-lab:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants