Speed up logic in ed.copy; distinguish reference tensor from tf.Variable #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the note in #471 (comment). As a minimal working example:
With this PR it succeeds; previously it fails (
tf.__version__ == '1.0.1'
). It was an issue where returning the reference tensor forces a downstream error when buildingWishartCholesky
; returning the associatedtf.Variable
fixes it.I also sped up some of the logic in
ed.copy
.