Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APR] PoolTable Filter #251
[APR] PoolTable Filter #251
Changes from all commits
39fc62c
92bf20f
f746676
76a7d7d
dbdd292
04135c9
300f999
7b68932
74d74dd
13ffa6f
bd35679
ab429ae
fa65ead
e097de9
7c2ea9c
194b68b
242bda1
c8d5b91
5e5f411
74e5953
92a6de6
cb289b6
806d9b9
ce936a4
99fa134
bf803ae
ae6635c
49bcf6e
102cf27
417c6e0
9e9df4b
4e86d1f
ac7c60c
0d8d87f
a6db0b7
0a9b69e
41fab0a
d29dfa3
50e60a0
013bc7d
f88a9a1
e2a924f
60186d2
ea8984a
f8f49b8
81cb3f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it wrap at some point and have some max width/height? How would this show on mobile? e.g. https://tools-monorepo-dxnj3a8mv-ribeirojose.vercel.app/apr/round/74?tokens=WETH%2CsdBal%2CB-80BAL-20WETH%2CjEUR%2Cbb-USD%2B%2CwstETH%2CDOLA%2CwBETH%2CwjAURA%2CswETH%2CstaBAL3%2CauraBAL%2CagEUR%2CPAR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From that above example ☝️ we also need an empty state when that search doesn't yield any results. Can you track that on Linear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it, do you think we should limit number os tokens to be searched at once?
cc @luizakp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked Balancer UI and they don't handle this case as well... from all the pool type the max amount of tokens is 8. So I think it makes sense to limit 8 tokens.WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keyboard arrow navigation doesn't work for this Select 😞 no need to work on this now since we've already put a lot of time here, but it's certainly something that's very intuitive to me that I couldn't use here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Downshift should help with that, I'll take a stab at it later