MB-61029: Deferring the closing of vector index #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Thejas-bhat
commented
Mar 12, 2024
•
Thejas-bhat
commented
- Uses the exponentially weighted moving average to get the average hits on a particular field (thereby a particular vector index). The index stays in the memory when the average of the hits is above a certain threshold and below which the index is closed and the memory is freed for reuse on C side of things.
- This ensures that we are not keeping the index in the memory even when there is no query workload on the field in a segment so the memory pressure does get reduced on the C side of operations.
Thejas-bhat
force-pushed
the
delayedClosing
branch
4 times, most recently
from
068f7af
to
d076ea2
Compare
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
Thejas-bhat
force-pushed
the
delayedClosing
branch
from
7273230
to
3338deb
Compare
abhinavdangeti
requested changes
Apr 4, 2024
abhinavdangeti
requested changes
Apr 5, 2024
There was a problem hiding this comment.
@Thejas-bhat still quite uneasy with the possibility of race-iness within this code.
|
@Thejas-bhat I'd appreciate an illustration on how this cache management is being done with ewma tracker - perhaps on the ticket or a document which we can attach to the ticket. |
Likith101
force-pushed
the
delayedClosing
branch
from
8376458
to
d202d4c
Compare
Thejas-bhat
force-pushed
the
delayedClosing
branch
from
e3fce1d
to
3d9f60d
Compare
abhinavdangeti
requested changes
Apr 9, 2024
abhinavdangeti
requested changes
Apr 10, 2024
|
Looking almost ready @Thejas-bhat 👍🏼 |
…cache - This prevents accidental clearing of cache entries while in use
- address review comments
Thejas-bhat
force-pushed
the
delayedClosing
branch
from
97f15cb
to
774b93d
Compare
abhinavdangeti
force-pushed
the
delayedClosing
branch
from
826fb28
to
1ca866b
Compare
abhinavdangeti
previously approved these changes
Apr 11, 2024
abhinavdangeti
approved these changes
Apr 11, 2024
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 18, 2024
Includes: * eeb2336 Likith B | MB-61029: Caching Vec To DocID Map (blevesearch/zapx#231) * b2384fc Rahul Rampure | minor optimizations and bug fixes (blevesearch/zapx#233) * b56abea Thejas-bhat | MB-61029: Deferring the closing of vector index (blevesearch/zapx#226)
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 18, 2024
Includes: * eeb2336 Likith B | MB-61029: Caching Vec To DocID Map (blevesearch/zapx#231) * b2384fc Rahul Rampure | minor optimizations and bug fixes (blevesearch/zapx#233) * b56abea Thejas-bhat | MB-61029: Deferring the closing of vector index (blevesearch/zapx#226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.