minor optimizations and bug fixes #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CascadingRadium
commented
Apr 12, 2024
•
CascadingRadium
commented
- Ensure slice capacities are accurately calculated to always be equal to the final slice length
- Fix test to cleanup zap segment after completion
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
|
@CascadingRadium would you add to the description above everything this change intends to do. |
abhinavdangeti
previously approved these changes
Apr 15, 2024
Thejas-bhat
reviewed
Apr 16, 2024
abhinavdangeti
approved these changes
Apr 16, 2024
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 18, 2024
Includes: * eeb2336 Likith B | MB-61029: Caching Vec To DocID Map (blevesearch/zapx#231) * b2384fc Rahul Rampure | minor optimizations and bug fixes (blevesearch/zapx#233) * b56abea Thejas-bhat | MB-61029: Deferring the closing of vector index (blevesearch/zapx#226)
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 18, 2024
Includes: * eeb2336 Likith B | MB-61029: Caching Vec To DocID Map (blevesearch/zapx#231) * b2384fc Rahul Rampure | minor optimizations and bug fixes (blevesearch/zapx#233) * b56abea Thejas-bhat | MB-61029: Deferring the closing of vector index (blevesearch/zapx#226)
moshaad7
pushed a commit
that referenced
this pull request
Sep 12, 2024
* minor optimizations and bug fixes * resolve comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.