Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yay testing! #8

Merged
merged 7 commits into from
Apr 4, 2014
Merged

Yay testing! #8

merged 7 commits into from
Apr 4, 2014

Conversation

davy
Copy link
Contributor

@davy davy commented Mar 7, 2014

It's pretty important that BenString is rock solid on all possible Ruby implementations. Except Jruby. And now Rubinius.

davy added 2 commits March 6, 2014 16:14
Use minitest hoe plugin, add minitest as dependency in Gemfile
Switch over from test unit style to minitest in tests
group :test do
gem 'minitest'
end

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETOOMUCHNEWLINE

davy added 5 commits March 8, 2014 17:23
Because it seems like way too much work.

'I don't care about Rubinius. Evan knows how I feel' - Ben
Since the test Gemfile group only contains the single minitest gem, we
can switch over to passing a group parameter to the minitest gem
dependency instead of explicitly creating a group.
My only goal in life has been to become a contributer to BenString, and
with this commit my dreams will have finally come true.
Guess I love the enter key too much
@davy
Copy link
Contributor Author

davy commented Mar 9, 2014

Ok, should be more better.

@davy
Copy link
Contributor Author

davy commented Apr 2, 2014

🐼

bleything added a commit that referenced this pull request Apr 4, 2014
@bleything bleything merged commit c8f7b3d into bleything:master Apr 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants