-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yay testing! #8
Merged
Merged
Yay testing! #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use minitest hoe plugin, add minitest as dependency in Gemfile
Switch over from test unit style to minitest in tests
group :test do | ||
gem 'minitest' | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ETOOMUCHNEWLINE
Because it seems like way too much work. 'I don't care about Rubinius. Evan knows how I feel' - Ben
Since the test Gemfile group only contains the single minitest gem, we can switch over to passing a group parameter to the minitest gem dependency instead of explicitly creating a group.
My only goal in life has been to become a contributer to BenString, and with this commit my dreams will have finally come true.
Guess I love the enter key too much
Ok, should be more better. |
🐼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty important that BenString is rock solid on all possible Ruby implementations. Except Jruby. And now Rubinius.