Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a spellchecker #725

Closed
LiquidityC opened this issue Jan 22, 2023 · 3 comments
Closed

Implement a spellchecker #725

LiquidityC opened this issue Jan 22, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request lua Lua implementation
Milestone

Comments

@LiquidityC
Copy link
Member

LiquidityC commented Jan 22, 2023

Description

To allow spellchecking in Blightmud we'll need to implement it.

Steps

@LiquidityC LiquidityC added enhancement New feature or request lua Lua implementation labels Jan 22, 2023
@cpu
Copy link
Member

cpu commented Jan 22, 2023

One aspect that might need some thought is how users will provide dictionary data and whether they need to source the data themselves or if it'll be bundled somehow.

In the Hunspell case (assuming that's what library #724 ends up using) the code will need to provide paths to both an affix file and a dictionary file. I found https://github.com/wooorm/dictionaries when I was looking around briefly. In my initial testing I followed the example from the Hunspell README and wget'd the OpenOffice en_US files to reference.

@LiquidityC
Copy link
Member Author

Anything GPL, MIT or Apache2 licensed should work here. I definitely think these files should be provided by lua through the lua bindings we build. It's best if users can change languages and provide their own dictionaries if they want to.

@cpu
Copy link
Member

cpu commented Feb 11, 2023

I put up a WIP PR with the Spellchecking API for: #736

Concurrent with that, I built a spellchecker plugin that uses the Spellchecking API to resolve this issue: https://github.com/cpu/blightspell

If you'd rather this be built-in to Blightmud I'm open to that but it felt better to build this separately as a plugin that we can iterate on faster than the Blightmud release schedule. LMK what you think.

The basic user experience is already pretty good. I think I can make it better still if #737 is also implemented.

@LiquidityC LiquidityC added this to the Version 5.1 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lua Lua implementation
Projects
Development

No branches or pull requests

2 participants