Use ArrayBuffer.isView rather than instanceof to distinguish between …

…views and array buffers.

Using instanceof to determine ArrayBuffers is fraught with problems in Javascript. See, for example, lodash’s implementation of isArrayBuffer, or the many isArrayBuffer libraries out there. Apparently, ArrayBuffers from a different context (like an iframe, or perhaps something in a test setup) so instanceof won’t work always. See feross/buffer#166 for some more examples.

packages/services/src/kernel/serialize.ts

@@ -84,7 +84,7 @@ function serializeBinary(msg: KernelMessage.IMessage): ArrayBuffer {
     // msg.buffers elements could be either views or ArrayBuffers
     // buffers elements are ArrayBuffers
     const b: any = origBuffers[i];
-    buffers.push(b instanceof ArrayBuffer ? b : b.buffer);
+    buffers.push(ArrayBuffer.isView(b) ? b.buffer : b);
   }
   const nbufs = buffers.length;
   offsets.push(4 * (nbufs + 1));