Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressWatcher sometimes fires callbacks every frame #127

Closed
jon-loubert opened this issue Jul 24, 2021 · 1 comment
Closed

ProgressWatcher sometimes fires callbacks every frame #127

jon-loubert opened this issue Jul 24, 2021 · 1 comment

Comments

@jon-loubert
Copy link
Member

When adding a watcher to a ProgressWatcher, if the range value is set to 0 or 1, the callback will sometimes be fired every frame, when it's supposed to only be fired once each time the threshold is crossed.

I have a workaround right now of just using 0.001 or 0.999 instead.
uxder added a commit that referenced this issue Jul 25, 2021
@uxder
fix: progressWatcher handling of 0 and 1 bounds (#127)
26d2d5b
@uxder
Copy link
Member

uxder commented Jul 25, 2021

@jon-loubert Thanks Jonathan for letting me know of this. v1.9.1 should fix the issue. Please reopen the issue if you still see it happening.

@uxder uxder closed this as completed Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uxder @jon-loubert