Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix playback error in lazy-video #297

Closed
wants to merge 1 commit into from
Closed

fix: fix playback error in lazy-video #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/dom/lazy-video.ts
View file
Open in desktop
Expand Up @@ -242,7 +242,9 @@ export class LazyVideo {
private playVideo() {
if (!dom.testVideoIsPlaying(this.video)) {
const playPromise = this.video.play();
playPromise.then(() => {}).catch();
if (playPromise !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can shorten this a little to something like:

if (playPromise) {
  playPromise.catch(() => {});
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and good point. I was kind of blindly following the notes here: https://developer.chrome.com/blog/play-request-was-interrupted/

playPromise.then(() => {}).catch(() => {});
}
}
}

Expand Down