Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full dependency resolution in AddDependencyExecutor #464

Closed
aem opened this issue May 7, 2020 · 3 comments
Closed

Enable full dependency resolution in AddDependencyExecutor #464

aem opened this issue May 7, 2020 · 3 comments

Comments

@aem
Copy link
Collaborator

aem commented May 7, 2020

What do you want and why?

Currently the AddDependencyExecutor just blindly installs the version specified in the executor's metadata, which isn't exactly what we want - we want a pinned version.

Possible implementation(s)

We should use the same dependency resolution logic we use in the blitz new command to resolve the latest valid version for each dependency based on the version string passed in (that may require pulling that logic out into a utility package for sharing, or just copy/pasting it.

@aem aem added kind/feature-change New feature or request status/ready-to-work-on This issue is up for grabs scope/installer labels May 7, 2020
@blitzjs-bot blitzjs-bot bot added this to Ready to Work On in Dashboard May 7, 2020
@merelinguist merelinguist self-assigned this May 24, 2020
@merelinguist merelinguist added status/icebox and removed status/ready-to-work-on This issue is up for grabs labels May 25, 2020
@blitzjs-bot blitzjs-bot bot moved this from Ready to Work On to Icebox in Dashboard May 25, 2020
@merelinguist
Copy link

it’s because the published version of the installer doesn’t try to install ts-node if it’s not already registered, which it is when yarn linked

Waiting on refactor

@aem aem moved this from Icebox to Ready to Work On in Dashboard Jun 7, 2020
@blitzjs-bot blitzjs-bot bot added status/ready-to-work-on This issue is up for grabs and removed status/icebox labels Jun 7, 2020
@aem
Copy link
Collaborator Author

aem commented Jun 7, 2020

@merelinguist finished that refactor, should be good to go now

@merelinguist
Copy link

@aem Thanks for the heads up :)

@blitzjs-bot blitzjs-bot added status/done and removed status/ready-to-work-on This issue is up for grabs labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Dashboard
Ready to Work On
Development

No branches or pull requests

4 participants