Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema for forward-request #21

Closed
wants to merge 7 commits into from
Closed

add schema for forward-request #21

wants to merge 7 commits into from

Conversation

ameba23
Copy link
Member

@ameba23 ameba23 commented Apr 2, 2019

No description provided.

@ameba23
Copy link
Member Author

ameba23 commented Apr 2, 2019

@KGibb8 you'll notice i didn't use ssb-invite-schema. i started out with that, but i had to make so many changes that in the end it was looking pretty ugly and hard to follow, so i started fresh.

so now there is no body property, but a secretOwner property which will contain the feedId of the person who's secret you are requesting to have forwarded.

we could have an additional property where you specify whether you are requesting all shards or just the one with a gossip.json attachment. but i couldn't make up my mind about it so i've left it out for now.

as you suggested, i was gonna add a branch attribute to forward messages. but i found there already is one! (we must have been thinking ahead!?) if you can think of any other properties they might need now there is a requests system lemme know.

@m4gpi
Copy link
Member

m4gpi commented Apr 10, 2019

Unified into single branch, see #22

@m4gpi m4gpi closed this Apr 10, 2019
@m4gpi m4gpi deleted the forward-request branch April 10, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants