This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
Single click copy #239
Merged
Single click copy #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ angular.module('walletApp').directive('singleClickSelect', ($window) -> | |||
|
|
|||
| if scope.browserCanExecCommand | |||
| $window.document.execCommand('copy') | |||
| scope.$digest() | |||
There was a problem hiding this comment.
Calling $digest directly can throw an error if angular is already in a $digest loop. Generally, it's better practice to call the $safeApply function defined in app.js: $scope.$root.$safeAppy(). This will do the same thing, but only if necessary. Article with more info.
|
Agree with @jtormey, looks good otherwise. |
plondon
force-pushed
the
single-click-copy
branch
from
407d6ed
to
f351937
Compare
|
Looks good now, don't worry about the decreased test coverage. Can you do a git rebase on beta, so that Github knows how to merge it? git checkout beta
git pull
git checkout single-click-copy
git rebase betaIf there are no conflicts: git push origin single-click-copy --force |
plondon
force-pushed
the
single-click-copy
branch
from
392c96a
to
9856ac2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.