This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
Support Chinese both as browser language and as setting #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtormey
added a commit
that referenced
this pull request
Jan 25, 2016
Support Chinese both as browser language and as setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to switch to Chinese if the browser language was not Chinese. I believe I fixed it now so that:
1 - when the browser language is Chinese, the registration form guesses Chinese as the language and sets the correct setting
2 - if the browser language is English, the user can switch to Chinese
I only tried this with simplified chinese, not with traditional chinese.