Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons #18

Closed
plondon opened this issue Jun 28, 2017 · 3 comments
Closed

Buttons #18

plondon opened this issue Jun 28, 2017 · 3 comments
Assignees
@plondon
Labels
enhancement An enhancement for an existing feature

Comments

@plondon
Copy link
Contributor

plondon commented Jun 28, 2017

Has anyone looked into buttons yet? Do you think we could move buttons.scss to a styled component instead? I can look into that.
@plondon plondon added the enhancement An enhancement for an existing feature label Jun 28, 2017
@Lyncee59
Copy link
Contributor

gonna investigate that today :)

@jtormey jtormey assigned plondon and unassigned Lyncee59 Jun 29, 2017
@jtormey
Copy link
Contributor

jtormey commented Jun 29, 2017

@plondon if you have a bit of spare time would be great if you could play around with styled-components in the context of existing css, specifically with components that are likely to be reused/extended (like Button).

@jtormey
Copy link
Contributor

jtormey commented Jul 5, 2017

We've created a wrapper Button component that encapsulates existing button css classes. Later, if we think it's necessary can convert to a styled-component.

@jtormey jtormey closed this as completed Jul 5, 2017
jtormey pushed a commit that referenced this issue Sep 6, 2017
@Lyncee59
Merge pull request #18 from blockchain/auto-logout
465aeda 
adds auto logout
plondon pushed a commit that referenced this issue Oct 25, 2018
@schnogz
Merge pull request #18 from blockchain/feat/balances-table
2cdb7be 
Feat/balances table
jjBlockchain pushed a commit that referenced this issue Aug 16, 2019
@lzhuor
Merge pull request #18 from blockchain/development
696d7d4 
Sync
schnogz added a commit that referenced this issue Aug 5, 2022
@TarasPotsikaylo @schnogz
added isPlugin checks for sign-up and sign-in components (#18)
ce17feb 
* feat(plugin): added plugin checks for sign-up components

* feat(plugin): added isPlugin checks for sign-up and sign-in components

Co-authored-by: Andrew Schneider <andrew@blockchain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plondon plondon

Labels
enhancement An enhancement for an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plondon @jtormey @Lyncee59