Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(withdraw): reset amount if bank changes #6273

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix(withdraw): reset amount if bank changes #6273

merged 1 commit into from
Feb 5, 2024

Conversation

mperdomo-bc
Copy link
Collaborator

No description provided.

mperdomo-bc
mperdomo-bc commented Feb 5, 2024
View reviewed changes
packages/blockchain-wallet-v4-frontend/src/modals/Brokerage/Banks/Withdraw/BankPicker/index.tsx
@@ -35,14 +35,12 @@ const BankPicker = ({ fiatCurrency, handleClose }: Props) => {
fiatCurrency={fiatCurrency}
bankTransferAccounts={data.bankTransferAccounts}
beneficiaries={data.beneficiaries}
defaultBeneficiary={data.defaultBeneficiary}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was passed down but never used

mperdomo-bc
mperdomo-bc commented Feb 5, 2024
View reviewed changes
packages/blockchain-wallet-v4-frontend/src/modals/Brokerage/Banks/Withdraw/BankPicker/index.tsx
defaultMethod={data.defaultMethod}
/>
)
}

export type BankPickerProps = {
beneficiary?: BeneficiaryType
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabbing this directly in the component instead of drilling down

mperdomo-bc
mperdomo-bc commented Feb 5, 2024
View reviewed changes
...allet-v4-frontend/src/modals/Brokerage/Banks/Withdraw/WithdrawalMethods/template.success.tsx
@@ -120,7 +120,7 @@ const Success = ({
size='20px'
color='grey600'
role='button'
onClick={handleClose}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, using the close function that modalEnhancer passes as is makes the page implode

mperdomo-bc
mperdomo-bc commented Feb 5, 2024
View reviewed changes
packages/blockchain-wallet-v4-frontend/src/modals/Brokerage/Banks/Withdraw/index.tsx
setTimeout(() => {
close()
}, duration)
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this logic is done by the ModalEnhancer automatically as long as the duration property is passed.

@mperdomo-bc mperdomo-bc merged commit 2ccf17d into development Feb 5, 2024
1 check passed
@mperdomo-bc mperdomo-bc deleted the fix-bank-change-withdraw branch February 5, 2024 22:52
mperdomo-bc added a commit that referenced this pull request Feb 9, 2024
@mperdomo-bc @TheLeoB
Release/v4.98.2 (#6280)
a58090d 
* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
mperdomo-bc added a commit that referenced this pull request Feb 26, 2024
@mperdomo-bc @TheLeoB @jhagerman-bc
Merge back release 4.98.4 to dev (#6303)
1c4c1a9 
* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>
mperdomo-bc added a commit that referenced this pull request Mar 5, 2024
@mperdomo-bc @TheLeoB @jhagerman-bc
Release/v4.98.00 (#6321)
ca5571f 
* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

* Release/v4.98.5 (#6305)

* fix(withdraw): put correct code after merge (#6304)

* chore(Release): v4.98.5

* Release/v4.98.6 (#6315)

* feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page

* chore(Release): v4.98.6

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.7 (#6320)

* feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date

* chore(Release): v4.98.7

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>
mperdomo-bc added a commit that referenced this pull request Mar 11, 2024
@mperdomo-bc @TheLeoB @jhagerman-bc
Release/v4.98.9 (#6325)
9ef5efe 
* Release/v4.98.00 (#6321)

* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

* Release/v4.98.5 (#6305)

* fix(withdraw): put correct code after merge (#6304)

* chore(Release): v4.98.5

* Release/v4.98.6 (#6315)

* feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page

* chore(Release): v4.98.6

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.7 (#6320)

* feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date

* chore(Release): v4.98.7

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>

* fix(balances): show balances when they are 0 (#6306)

* chore(form): use error returned form BE if available (#6313)

* fix(verify): show verify email when it should (#6324)

* chore(Release): v4.98.8

* chore(Release): v4.98.9

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>
mperdomo-bc added a commit that referenced this pull request Mar 11, 2024
@mperdomo-bc @TheLeoB @jhagerman-bc
Release/v4.98.00 (#6341)
cf80a0b 
* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

* Release/v4.98.5 (#6305)

* fix(withdraw): put correct code after merge (#6304)

* chore(Release): v4.98.5

* Release/v4.98.6 (#6315)

* feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page

* chore(Release): v4.98.6

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.7 (#6320)

* feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date

* chore(Release): v4.98.7

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.8 (#6323)

* fix(balances): show balances when they are 0 (#6306)

* chore(form): use error returned form BE if available (#6313)

* chore(Release): v4.98.8

* Release/v4.98.9 (#6325)

* Release/v4.98.00 (#6321)

* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

* Release/v4.98.5 (#6305)

* fix(withdraw): put correct code after merge (#6304)

* chore(Release): v4.98.5

* Release/v4.98.6 (#6315)

* feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page

* chore(Release): v4.98.6

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.7 (#6320)

* feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date

* chore(Release): v4.98.7

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>

* fix(balances): show balances when they are 0 (#6306)

* chore(form): use error returned form BE if available (#6313)

* fix(verify): show verify email when it should (#6324)

* chore(Release): v4.98.8

* chore(Release): v4.98.9

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>
mperdomo-bc added a commit that referenced this pull request Mar 13, 2024
@mperdomo-bc @TheLeoB @jhagerman-bc
Release/v4.89.10 (#6342)
0887239 
* Release/v4.98.00 (#6341)

* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

* Release/v4.98.5 (#6305)

* fix(withdraw): put correct code after merge (#6304)

* chore(Release): v4.98.5

* Release/v4.98.6 (#6315)

* feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page

* chore(Release): v4.98.6

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.7 (#6320)

* feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date

* chore(Release): v4.98.7

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.8 (#6323)

* fix(balances): show balances when they are 0 (#6306)

* chore(form): use error returned form BE if available (#6313)

* chore(Release): v4.98.8

* Release/v4.98.9 (#6325)

* Release/v4.98.00 (#6321)

* Release/v4.98.2 (#6280)

* chore(refactor): refactor bank picker (#6263)

* fix(withdraw): reset amount if bank changes (#6273)

* Cleanup withdrawal (#6275)

* chore(refactor): cleanup withdraw confirm & methods

* chore(withdraw): refactor on hold, model, confirm

* chore(settigs): do not rerender if pairing flag does not change (#6276)

* Withdraw - do not have ACH bank selected by default (#6277)

* chore(withdraw): use dispatch in EnterAmount

* feat(withdraw): do not allow selection of ach for withdraw

* feat(quiz): send event on quiz start (#6279)

* chore(Release): v4.98.2

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>

* feat(chart-finprom): added finprom text under the chart for UK folks

* feat(chart-finprom): changed mesg ids

* chore(Release): v4.98.3

* chore(Release): v4.98.4

* Release/v4.98.5 (#6305)

* fix(withdraw): put correct code after merge (#6304)

* chore(Release): v4.98.5

* Release/v4.98.6 (#6315)

* feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page

* chore(Release): v4.98.6

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

* Release/v4.98.7 (#6320)

* feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date

* chore(Release): v4.98.7

---------

Co-authored-by: John Hagerman <jhagerman@blockchain.com>

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>

* fix(balances): show balances when they are 0 (#6306)

* chore(form): use error returned form BE if available (#6313)

* fix(verify): show verify email when it should (#6324)

* chore(Release): v4.98.8

* chore(Release): v4.98.9

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>

* chore(Release): v4.98.10

---------

Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
Co-authored-by: John Hagerman <jhagerman@blockchain.com>
Co-authored-by: Leora Brody <leora@blockchain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjBlockchain jjBlockchain jjBlockchain approved these changes

@TheLeoB TheLeoB Awaiting requested review from TheLeoB TheLeoB is a code owner

@milan-bc milan-bc Awaiting requested review from milan-bc milan-bc is a code owner

@dkremniov-bc dkremniov-bc Awaiting requested review from dkremniov-bc dkremniov-bc is a code owner

@mrodriguez-bc mrodriguez-bc Awaiting requested review from mrodriguez-bc mrodriguez-bc is a code owner

@CTucker-BC CTucker-BC Awaiting requested review from CTucker-BC CTucker-BC is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mperdomo-bc @jjBlockchain