-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Withdraw - do not have ACH bank selected by default #6277
Conversation
& > div { | ||
width: 100% !important; | ||
} | ||
` | ||
|
||
const noOp = () => {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this empty callback function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onClick
is required down below but it shouldn't be used. Having it here so I don't have to inline it and it does not get recreated every time.
* chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com>
* Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com>
* Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 * Release/v4.98.5 (#6305) * fix(withdraw): put correct code after merge (#6304) * chore(Release): v4.98.5 * Release/v4.98.6 (#6315) * feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page * chore(Release): v4.98.6 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.7 (#6320) * feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date * chore(Release): v4.98.7 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com>
* Release/v4.98.00 (#6321) * Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 * Release/v4.98.5 (#6305) * fix(withdraw): put correct code after merge (#6304) * chore(Release): v4.98.5 * Release/v4.98.6 (#6315) * feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page * chore(Release): v4.98.6 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.7 (#6320) * feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date * chore(Release): v4.98.7 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com> * fix(balances): show balances when they are 0 (#6306) * chore(form): use error returned form BE if available (#6313) * fix(verify): show verify email when it should (#6324) * chore(Release): v4.98.8 * chore(Release): v4.98.9 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com>
* Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 * Release/v4.98.5 (#6305) * fix(withdraw): put correct code after merge (#6304) * chore(Release): v4.98.5 * Release/v4.98.6 (#6315) * feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page * chore(Release): v4.98.6 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.7 (#6320) * feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date * chore(Release): v4.98.7 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.8 (#6323) * fix(balances): show balances when they are 0 (#6306) * chore(form): use error returned form BE if available (#6313) * chore(Release): v4.98.8 * Release/v4.98.9 (#6325) * Release/v4.98.00 (#6321) * Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 * Release/v4.98.5 (#6305) * fix(withdraw): put correct code after merge (#6304) * chore(Release): v4.98.5 * Release/v4.98.6 (#6315) * feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page * chore(Release): v4.98.6 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.7 (#6320) * feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date * chore(Release): v4.98.7 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com> * fix(balances): show balances when they are 0 (#6306) * chore(form): use error returned form BE if available (#6313) * fix(verify): show verify email when it should (#6324) * chore(Release): v4.98.8 * chore(Release): v4.98.9 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com> --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com>
* Release/v4.98.00 (#6341) * Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 * Release/v4.98.5 (#6305) * fix(withdraw): put correct code after merge (#6304) * chore(Release): v4.98.5 * Release/v4.98.6 (#6315) * feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page * chore(Release): v4.98.6 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.7 (#6320) * feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date * chore(Release): v4.98.7 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.8 (#6323) * fix(balances): show balances when they are 0 (#6306) * chore(form): use error returned form BE if available (#6313) * chore(Release): v4.98.8 * Release/v4.98.9 (#6325) * Release/v4.98.00 (#6321) * Release/v4.98.2 (#6280) * chore(refactor): refactor bank picker (#6263) * fix(withdraw): reset amount if bank changes (#6273) * Cleanup withdrawal (#6275) * chore(refactor): cleanup withdraw confirm & methods * chore(withdraw): refactor on hold, model, confirm * chore(settigs): do not rerender if pairing flag does not change (#6276) * Withdraw - do not have ACH bank selected by default (#6277) * chore(withdraw): use dispatch in EnterAmount * feat(withdraw): do not allow selection of ach for withdraw * feat(quiz): send event on quiz start (#6279) * chore(Release): v4.98.2 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> * feat(chart-finprom): added finprom text under the chart for UK folks * feat(chart-finprom): changed mesg ids * chore(Release): v4.98.3 * chore(Release): v4.98.4 * Release/v4.98.5 (#6305) * fix(withdraw): put correct code after merge (#6304) * chore(Release): v4.98.5 * Release/v4.98.6 (#6315) * feat(update-finprom-approver-text): updated finprom approval text from being form Helford to Englebert and updated the date, also update finprom text on prices page * chore(Release): v4.98.6 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> * Release/v4.98.7 (#6320) * feat(update-finprom-apy-text): updated text on earn, fixed btc anf gyp page date * chore(Release): v4.98.7 --------- Co-authored-by: John Hagerman <jhagerman@blockchain.com> --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com> * fix(balances): show balances when they are 0 (#6306) * chore(form): use error returned form BE if available (#6313) * fix(verify): show verify email when it should (#6324) * chore(Release): v4.98.8 * chore(Release): v4.98.9 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com> --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com> * chore(Release): v4.98.10 --------- Co-authored-by: TheLeoB <TheLeoB@users.noreply.github.com> Co-authored-by: John Hagerman <jhagerman@blockchain.com> Co-authored-by: Leora Brody <leora@blockchain.com>
We don't currently support this type of withdrawal, so do not select that as default method