Update api.py #72
Closed
Update api.py #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinlesceller
suggested changes
Jan 9, 2020
There was a problem hiding this comment.
Hi @Latand. Thank you for the PR!
Unfortunately, it won't work as is and also changes the default behavior. See the two comments.
| @@ -1585,7 +1585,7 @@ def broadcast_signed_transaction(unsigned_tx, signatures, pubkeys, coin_symbol=' | |||
|
|
|||
|
|
|||
| def simple_spend(from_privkey, to_address, to_satoshis, change_address=None, | |||
| privkey_is_compressed=True, min_confirmations=0, api_key=None, coin_symbol='btc'): | |||
| privkey_is_compressed=True, min_confirmations=0, api_key=None, coin_symbol='btc', fees=None, preference='low'): | |||
There was a problem hiding this comment.
Thanks for the PR. However here you are changing the default preference from high to low. See here
blockcypher-python/blockcypher/api.py
Line 1296 in 4e90639
| @@ -1626,6 +1626,8 @@ def simple_spend(from_privkey, to_address, to_satoshis, change_address=None, | |||
| unsigned_tx = create_unsigned_tx( | |||
| inputs=inputs, | |||
| outputs=outputs, | |||
| fees=fees, | |||
There was a problem hiding this comment.
There is no such field in create_unsigned_tx function.
|
Closing due to lack of activity. Feel free to rebase and reopen a PR. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added fees and preference parameters to the simple_send function.