test: Created unit tests to implement native ethers transfer #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xneves
reviewed
May 17, 2024
test/TestSwaplace.test.ts
Outdated
| const askingAmountOrId = [50, 100, 150]; | ||
|
|
||
| const valueToSend: BigNumber = ethers.utils.parseEther("0.5"); | ||
|
|
0xneves
requested changes
May 17, 2024
test/TestSwaplace.test.ts
Outdated
| const valueToSend: BigNumber = ethers.utils.parseEther("0.5"); | ||
|
|
||
| const expiry = (await blocktimestamp()) + 1000000; | ||
|
|
test/TestSwaplace.test.ts
Outdated
| const askingAmountOrId = [50, 100, 150]; | ||
|
|
||
| const valueToSend: BigNumber = ethers.utils.parseEther("0.5"); | ||
|
|
test/TestSwaplace.test.ts
Outdated
| const valueToSend: BigNumber = ethers.utils.parseEther("0.5"); | ||
|
|
||
| const expiry = (await blocktimestamp()) + 1000000; | ||
|
|
test/TestSwaplace.test.ts
Outdated
| @@ -326,6 +326,44 @@ describe("Swaplace", async function () { | |||
| .to.emit(Swaplace, "SwapCreated") | |||
| .withArgs(await Swaplace.totalSwaps(), owner.address, zeroAddress); | |||
| }); | |||
|
|
|||
| it("Should be able to create a swap with native ethers", async function () { | |||
There was a problem hiding this comment.
Use "by the owner" refer, like in line 377
test/TestSwaplace.test.ts
Outdated
| @@ -466,6 +538,69 @@ describe("Swaplace", async function () { | |||
| allowed.address, | |||
| ); | |||
| }); | |||
|
|
|||
| it("Should be able to {acceptSwap} with native ethers", async function () { | |||
|
Hey @0xneves made the requested changes. Ready for review |
0xneves
requested changes
May 19, 2024
test/TestSwaplace.test.ts
Outdated
| @@ -339,7 +339,7 @@ describe("Swaplace", async function () { | |||
| const askingAmountOrId = [50, 100, 150]; | |||
|
|
|||
| const valueToSend: BigNumber = ethers.utils.parseEther("0.5"); | |||
|
|
|||
There was a problem hiding this comment.
Unnecessary whitespace was added here
There was a problem hiding this comment.
@0xneves sorry, removed it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #206