Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch Events Android #203

Closed
lnbc1QWFyb24 opened this issue May 23, 2019 · 0 comments · Fixed by #204
Closed

Touch Events Android #203

lnbc1QWFyb24 opened this issue May 23, 2019 · 0 comments · Fixed by #204
Assignees
@lnbc1QWFyb24
Labels
bug Something isn't working

Comments

@lnbc1QWFyb24
Copy link
Collaborator

Currently when touching a modal without swiping on android causes the modal to close. Because of this, closeModal is being called twice when pressing the "check I am connected" button. Looking further in to this it turns out that touch.pageY is registering a large difference in pixels from when the touchstart event is registered and when touchend event is registered even when no distance has been covered (no swipe). This distance causes our code to register as a validSwipe when it isn't. Need to look in to why pageY is functioning differently on Android devices.
@lnbc1QWFyb24 lnbc1QWFyb24 added the bug Something isn't working label May 23, 2019
@lnbc1QWFyb24 lnbc1QWFyb24 self-assigned this May 23, 2019
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this issue May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lnbc1QWFyb24 lnbc1QWFyb24

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change pageY and pageX to screenY and screenX blocknative/assist
1 participant
@lnbc1QWFyb24