change pageY and pageX to screenY and screenX #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeisl
approved these changes
May 23, 2019
cmeisl
added a commit
that referenced
this pull request
May 24, 2019
* resize iframe after hiding modal (#198) * update readme with mobile support info and web3 initialization example (#200) * update readme with mobile support info and web3 initialization example * add mobile section * update to version 0.8.1 * change pageY and pageX to screenY and screenX (#204) * add correct click handlers to close button touch start event (#206)
Merged
cmeisl
added a commit
that referenced
this pull request
May 24, 2019
* resize iframe after hiding modal (#198) * update readme with mobile support info and web3 initialization example (#200) * update readme with mobile support info and web3 initialization example * add mobile section * update to version 0.8.1 * change pageY and pageX to screenY and screenX (#204) * add correct click handlers to close button touch start event (#206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #203
Switching
pageYandpageXforscreenYandscreenXproduces the desired results across platforms.