Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix : revert tp gasUsed addition for Type2 transactions #1537

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Feb 17, 2023

Description

Revert TP gasUsed addition until we can properly handle type2 transactions for gasUsed

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ❌ Failed (Inspect) Feb 17, 2023 at 7:20PM (UTC)

@Adamj1232 Adamj1232 merged commit 740899f into develop Feb 17, 2023
@Adamj1232 Adamj1232 deleted the hot-fix/revert_TP_gas_edition branch February 17, 2023 19:28
@Adamj1232 Adamj1232 changed the title Hot fix : revert tp gasUsed addition Hot fix : revert tp gasUsed addition for Type2 Feb 17, 2023
@Adamj1232 Adamj1232 changed the title Hot fix : revert tp gasUsed addition for Type2 Hot fix : revert tp gasUsed addition for Type2 transactions Feb 17, 2023
This was referenced Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants