Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-v2.15.3-alpha.2]: Fix - Add config to disable Unstoppable Domains resolution #1556

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Feb 27, 2023

Description

This PR adds a configuration to the W3O init within the connect object called disableUDResolution which allows disabling of Unstoppable Domains Resolution. This PR also makes the import of the @unstoppabledomains/resolution package dynamic so if this is set to false the bundle size can be further reduced

export interface InitOptions {
  /**
   * Customize the connect modal
   */
  connect?: ConnectModalOptions
....
}

export type ConnectModalOptions = {
  /**
   * Define support for Unstoppable Domains resolutions
   * after a user connects. Similar to ens, uns can be used for users who
   * have minted an Unstoppable Domain and associated it with their wallet.
   * ENS resolution takes precedent over UNS
   * Defaults to false
   */
    disableUDResolution?: boolean
....
}

Closes: #1513

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 7:53PM (UTC)

* after a user connects. Similar to ens, uns can be used for users who
* have minted an Unstoppable Domain and associated it with their wallet.
* ENS resolution takes precedent over UNS
* Defaults to true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be false! @Adamj1232

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed on the release branch, #1557

@JohannesHoppe
Copy link

Great work! I updated to @web3-onboard/core@2.15.3-alpha.2 and the error is finally gone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unstoppable Domains resolution error
3 participants