-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-v2.15.3-alpha.2]: Fix - Add config to disable Unstoppable Domains resolution #1556
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* after a user connects. Similar to ens, uns can be used for users who | ||
* have minted an Unstoppable Domain and associated it with their wallet. | ||
* ENS resolution takes precedent over UNS | ||
* Defaults to true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be false
! @Adamj1232
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed on the release branch, #1557
Great work! I updated to @web3-onboard/core@2.15.3-alpha.2 and the error is finally gone! |
Description
This PR adds a configuration to the W3O init within the
connect
object calleddisableUDResolution
which allows disabling of Unstoppable Domains Resolution. This PR also makes the import of the@unstoppabledomains/resolution
package dynamic so if this is set to false the bundle size can be further reducedCloses: #1513
Checklist
package.json
of the package you have made changes in is incremented following semantic versioning and using alpha release taggingyarn file-check
,yarn type-check
&yarn build
to confirm there are not any associated errors