Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve installation for PS version > 8.0.1 #161

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

anktd
Copy link
Contributor

@anktd anktd commented Jun 22, 2023

This PR aims to fix #160


Changes done -
in blockonomics.php , Changing the ps_versions_compliancy array from
$this->ps_versions_compliancy = [ 'min' => '8.0', 'max' => '8.0.1',];
to
$this->ps_versions_compliancy = [ 'min' => '8.0', 'max' => _PS_VERSION_,];

Note that this is similar to our plugin for PS version 1.7.


PS Validator Results:
Validator is passing all except compatibility which seems to be related to this array. However, Compatibility tab is unclickable so we can not be sure and report is also not downloading as PS Validator throws 5XX error.

image

Copy link
Collaborator

@DarrenWestwood DarrenWestwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Compatibility Tab error is an issue in the Prestashop Validator. This can be confirmed by generating a new payment gateway module using the Prestashop Module Generator, which will also cause the same issue in the validator. This appears to be a similar issue to one they patched previously.
PrestaShop-Validator

@DarrenWestwood DarrenWestwood merged commit 2090e86 into blockonomics:8.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants