-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add petersburg evm version to smart contract verifier #1650
Conversation
Pull Request Test Coverage Report for Build 14b6a17e-0f05-4b03-b90b-c51bf45adea4
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a new ENV version petersburg
in the select.
Didn't you forget to add it to https://github.com/poanetwork/blockscout/blob/0c67eae2f315668b548925ca20d55d57bf5bd823/apps/block_scout_web/lib/block_scout_web/controllers/address_contract_verification_controller.ex#L7 ?
And why do we have a list of EVM versions in two places in the code? Could we define it once?
@vbaranov my bad. I fixed it |
I've tested it in Sokol. And no, verification doesn't work for me for just created smart-contract in Sokol. contract address:
|
failed. Please take a look. |
Changelog