Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add petersburg evm version to smart contract verifier #1650

Merged
merged 6 commits into from
Mar 27, 2019

Conversation

ayrat555
Copy link
Contributor

Changelog

  • add petersburg evm version to smart contract verifier
  • make petersburg default evm version

@ghost ghost assigned ayrat555 Mar 25, 2019
@ghost ghost added the in progress label Mar 25, 2019
@coveralls
Copy link

coveralls commented Mar 25, 2019

Pull Request Test Coverage Report for Build 14b6a17e-0f05-4b03-b90b-c51bf45adea4

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 83.254%

Totals Coverage Status
Change from base Build fa78c39f-3560-4dee-ae87-834dbc4dd4c2: 0.1%
Covered Lines: 4350
Relevant Lines: 5225

💛 - Coveralls

@ghost ghost assigned vbaranov Mar 26, 2019
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

I don't see a new ENV version petersburg in the select.

Didn't you forget to add it to https://github.com/poanetwork/blockscout/blob/0c67eae2f315668b548925ca20d55d57bf5bd823/apps/block_scout_web/lib/block_scout_web/controllers/address_contract_verification_controller.ex#L7 ?

And why do we have a list of EVM versions in two places in the code? Could we define it once?

@ayrat555
Copy link
Contributor Author

@vbaranov my bad. I fixed it

@vbaranov
Copy link
Member

@ayrat555

I've tested it in Sokol. And no, verification doesn't work for me for just created smart-contract in Sokol.

contract address: 0x41b3b1c86cf44d04e39077be109533d0304b5773
source code:

pragma solidity ^0.5.6;

contract testContract {
    uint public num;
    
    function setStr(uint val) public {
        num = val;
    }
    
    function getStr() public view returns (uint) {
        return num;
    }
}

screencapture-localhost-4000-address-0x41b3b1c86cf44d04e39077be109533d0304b5773-contract_verifications-2019-03-26-13_52_44

@vbaranov vbaranov self-requested a review March 26, 2019 11:35
@vbaranov
Copy link
Member

@ayrat555

test/block_scout_web/features/address_contract_verification_test.exs:16

failed. Please take a look.

@ayrat555 ayrat555 added the ready for review This PR is ready for reviews. label Mar 27, 2019
@vbaranov vbaranov merged commit ad3c86f into master Mar 27, 2019
@ghost ghost removed the in progress label Mar 27, 2019
@vbaranov vbaranov deleted the ab-add-petersburg-evm-version branch March 27, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants