Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to compile with the latest evm version if bytecode doesn't match #1661

Merged
merged 4 commits into from
Mar 29, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #1653

Motivation

If user-provided evm version is wrong, we can try to verify contract using the latest evm version. If we couldn't verify the contract with the latest evm version we will try the version before the latest version.

Changelog

  • try to compile with the latest evm version if bytecode doesn't match

@ghost ghost assigned ayrat555 Mar 27, 2019
@ghost ghost added the in progress label Mar 27, 2019
@ayrat555 ayrat555 added the ready for review This PR is ready for reviews. label Mar 27, 2019
@coveralls
Copy link

coveralls commented Mar 27, 2019

Pull Request Test Coverage Report for Build 26634b26-4544-4e62-939d-d8504e4f4d51

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 82.865%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/smart_contract/verifier.ex 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 1 65.85%
apps/indexer/lib/indexer/token/fetcher.ex 1 78.57%
apps/indexer/lib/indexer/token_balance/fetcher.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 2 91.67%
Totals Coverage Status
Change from base Build b5b5f7cf-c2df-4e0e-b629-3443411ab8ab: -0.3%
Covered Lines: 4420
Relevant Lines: 5334

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contracts verification: fallback to 2 closest EVM versions
4 participants