Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not fail if multiple matching tokens are found #1669

Merged
merged 3 commits into from
Mar 29, 2019
Merged

do not fail if multiple matching tokens are found #1669

merged 3 commits into from
Mar 29, 2019

Conversation

ayrat555
Copy link
Contributor

When a user searches token by its name multiple matching addresses can be found

Changelog

  • do not fail if multiple matching tokens are found

@ghost ghost assigned ayrat555 Mar 28, 2019
@ghost ghost added the in progress label Mar 28, 2019
@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build a603f943-40d7-4231-acbd-dd92631e1973

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 82.952%
Totals Coverage Status
Change from base Build b9136906-80b0-4a31-8910-f45645ae4107: 0.09%
Covered Lines: 4418
Relevant Lines: 5326
💛 - Coveralls

@ayrat555 ayrat555 added the ready for review This PR is ready for reviews. label Mar 28, 2019
goodsoft
goodsoft approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@goodsoft goodsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note here, that this is a temporary fix before proper solution is implemented as part of #1670.

goodsoft
goodsoft reviewed Mar 28, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -4,6 +4,8 @@

### Fixes

- [#1669](https://github.com/poanetwork/blockscout/pull/1669) - https://github.com/poanetwork/blockscout/pull/1669
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@ayrat555 ayrat555 merged commit 1b4172e into master Mar 29, 2019
@ghost ghost removed the in progress label Mar 29, 2019
@ayrat555 ayrat555 deleted the ab-fix-search-by-token-name branch March 29, 2019 07:56
@ayrat555 ayrat555 mentioned this pull request Apr 8, 2019
Merged
@igorbarinov igorbarinov mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees

@ayrat555 ayrat555

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayrat555 @coveralls @goodsoft @vbaranov