Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail if failure reason is atom #1688

Merged
merged 3 commits into from
Apr 1, 2019
Merged

do not fail if failure reason is atom #1688

merged 3 commits into from
Apr 1, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Apr 1, 2019

fixes #1682

sometimes requests return atoms as a reason for request failure. For example, {:error, :closed} or {:error, :request_timeout}. these atome were raised raise :closed which is caused the error.

Changelog

  • do not fail if failure reason is atom

@ghost ghost assigned ayrat555 Apr 1, 2019
@ghost ghost added the in progress label Apr 1, 2019
@ayrat555 ayrat555 added the ready for review This PR is ready for reviews. label Apr 1, 2019
@coveralls
Copy link

coveralls commented Apr 1, 2019

Pull Request Test Coverage Report for Build b6d6f10b-cd26-4310-9f9c-68f5508189a8

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 83.025%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/contract.ex 0 1 0.0%
Totals Coverage Status
Change from base Build 0eea6466-7f76-42cf-b622-4045b3eeb709: 0.003%
Covered Lines: 4446
Relevant Lines: 5355

💛 - Coveralls

@ayrat555 ayrat555 merged commit 9230a09 into master Apr 1, 2019
@ayrat555 ayrat555 deleted the ab-fix-atom-reason branch April 1, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexer.TokenBalance.Fetcher fails when indexing Rinkeby
4 participants