add timestamp to block overview #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build ba05a21c-7769-4fe3-a79d-72bbc39a6b5f
💛 - Coveralls |
vbaranov
requested changes
Apr 18, 2019
| @@ -22,7 +22,7 @@ function updateAge (el, timestamp) { | |||
| let fromNow = timestamp.fromNow() | |||
| // show the exact time only for transaction details page. Otherwise, short entry | |||
| const elInTile = el.hasAttribute('in-tile') | |||
| if (window.location.pathname.includes('/tx/') && !elInTile) { | |||
| if ((window.location.pathname.includes('/tx/') || window.location.pathname.includes('/blocks/')) && !elInTile) { | |||
There was a problem hiding this comment.
@ayrat555in We need to display a full time only in the block details:
I suppose, after these changes, the full time will be displayed in tiles also 
, and it will break the tile view.
Datetime elements in tiles should be marked with an attribute in-tile
There was a problem hiding this comment.
@vbaranov I think everything's ok
There was a problem hiding this comment.
Oh, cool. Could you please check /blocks page with all blocks. Are the tiles not broken there?
There was a problem hiding this comment.
yes, it's ok because I didn't delete !elInTile
vbaranov
approved these changes
Apr 18, 2019
goodsoft
approved these changes
Apr 18, 2019
zachdaniel
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1764
Changelog