optionally show ERC-20 token transfer info #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build e397eb3e-6c41-4022-86af-5533859ce0a0
💛 - Coveralls |
ayrat555
changed the title
goodsoft
reviewed
Apr 18, 2019
| _ -> | ||
| nil | ||
| end | ||
| end |
There was a problem hiding this comment.
Can't we find the corresponding transfer by token_transfer.transaction_hash?
There was a problem hiding this comment.
there can be multiple token transfers for a single transaction
There was a problem hiding this comment.
Why do we only show one then?
There was a problem hiding this comment.
we only show the one that is in the main transaction like in value transfer. in value transfer transaction we only show value from the main transaction
There was a problem hiding this comment.
It would make more sense to calculate this once in Indexer.Transform.TokenTransfers in this case, but that's probably a task for another PR.
zachdaniel
approved these changes
Apr 18, 2019
goodsoft
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1732
Changelog
optionally show ERC-20 token transfer info on the transaction page