Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ERC-721 info to transaction overview page #1789

Merged
merged 5 commits into from
Apr 22, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

img

with #1777 resolves #1732

Changelog

  • add ERC-721 info to the transaction overview page

@ghost ghost assigned ayrat555 Apr 19, 2019
@ghost ghost added the in progress label Apr 19, 2019
@coveralls
Copy link

coveralls commented Apr 19, 2019

Pull Request Test Coverage Report for Build 988fc4bd-afb5-4412-bb6e-ac38d49c3ade

  • 9 of 17 (52.94%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 82.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/transaction_view.ex 9 17 52.94%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 69.23%
Totals Coverage Status
Change from base Build d15b0502-62d6-4cbf-9abe-4eefc6e03fe3: -0.09%
Covered Lines: 4433
Relevant Lines: 5350

💛 - Coveralls

# https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/token/ERC721/ERC721.sol#L35
{from_address, to_address} =
case {to_string(input), value} do
{"0x23b872dd" <> params, ^zero_wei} ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 can we add a comment here and below to which method it belongs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@goodsoft goodsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, I'm not a fan of putting token transfer parsing logic in Web UI.
Especially when we parse them out in indexer already anyway.
I hope this won't stay past #1792.

@ayrat555 ayrat555 merged commit ec7f695 into master Apr 22, 2019
@ayrat555 ayrat555 deleted the ab-erc721-info branch April 22, 2019 07:26
@ghost ghost removed the in progress label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Token specific details in the Transfer Details page if it was a token's operation
5 participants